Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pending leak #3270

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix pending leak #3270

merged 1 commit into from
Jan 10, 2022

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Jan 9, 2022 •
edited
Loading

What is changed and how it works?

fix memory leak introduce from #3264

Check List

Tests

  • Unit test
    previous will get failures:
    component::tests::pending::test_basic
    component::tests::pending::test_fill_proposals
    component::tests::pending::test_resolve_conflict_header_dep
failures:

---- component::tests::pending::test_basic stdout ----
thread 'component::tests::pending::test_basic' panicked at 'assertion failed: `(left == right)`
  left: `8`,
 right: `4`', tx-pool/src/component/tests/pending.rs:26:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- component::tests::pending::test_fill_proposals stdout ----
thread 'component::tests::pending::test_fill_proposals' panicked at 'assertion failed: `(left == right)`
  left: `13`,
 right: `7`', tx-pool/src/component/tests/pending.rs:204:5

---- component::tests::pending::test_resolve_conflict_header_dep stdout ----
thread 'component::tests::pending::test_resolve_conflict_header_dep' panicked at 'assertion failed: `(left == right)`
  left: `4`,
 right: `2`', tx-pool/src/component/tests/pending.rs:121:5

Release note 

None: Exclude this PR from the release note.
Title Only: Include only the PR title in the release note.
Note: Add a note under the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner January 9, 2022 20:04
@quake
Copy link
Member

quake commented Jan 10, 2022

bors r=quake,yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build succeeded:

@bors bors bot merged commit 0eb94fa into nervosnetwork:develop Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@quake quake quake approved these changes

@keroro520 keroro520 Awaiting requested review from keroro520 keroro520 is a code owner automatically assigned from nervosnetwork/ckb-dev

@liya2017 liya2017 Awaiting requested review from liya2017 liya2017 is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @quake @yangby-cryptape